Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FastQC #115

Closed
grst opened this issue Jun 17, 2022 · 2 comments · Fixed by #121
Closed

Add FastQC #115

grst opened this issue Jun 17, 2022 · 2 comments · Fixed by #121
Milestone
2.1.0

Comments

@grst
Copy link
Member

grst commented Jun 17, 2022

#32 was an attempt to add FastQC to the workflow. This PR is obsolete as it was against the DSL1 version.

I still believe it would be nice to have FastQC reports in addition to the downstream quality metrics (#80)
@apeltzer apeltzer added this to the 2.1.0 milestone Jun 17, 2022
@grst grst linked a pull request Jun 29, 2022 that will close this issue
Dev - Adding FastQC to the pipeline, with integration into MultiQC #121
Merged
10 tasks
@heylf
Copy link
Contributor

heylf commented Jun 30, 2022

I made a PR for that.

@grst
Copy link
Member Author

grst commented Jul 5, 2022

PR was merged.

@grst grst closed this as completed Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

Successfully merging a pull request may close this issue.

Dev - Adding FastQC to the pipeline, with integration into MultiQC
3 participants
@apeltzer @grst @heylf