Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent default protocol #189

Closed
martinkim0 opened this issue Dec 14, 2022 · 3 comments
Closed

Inconsistent default protocol #189

martinkim0 opened this issue Dec 14, 2022 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@martinkim0
Copy link

Description of the bug

Currently, nextflow_schema.json lists 10XV2 as the default protocol, so that is what is displayed in the docs. However, it looks like 10XV3 is actually the default being used as seen in nextflow.config.

Command used and terminal output

No response

Relevant files

No response

System information

nf-core/scrnaseq dev

@martinkim0 martinkim0 added the bug Something isn't working label Dec 14, 2022
@grst
Copy link
Member

grst commented Dec 19, 2022

And it should actually be removed from both and be part of the samplesheet, s.t. protocol can bet set on a per-sample basis.

I thought this was implemented long time ago, but probably it never was? @fmalmeida, @apeltzer?

@ameynert removed the protocol from the test samplesheet in nf-core/test-datasets@fdd2d2b. Did I miss something (maybe during the hackathon) or was it just not implemented and therefore removed from the samplesheet to not be misleading?

@apeltzer
Copy link
Member

Guess that was not implemented but would have to dig myself what in the end was (not) done.

@grst grst added this to scrnaseq Feb 21, 2023
@github-project-automation github-project-automation bot moved this to Todo in scrnaseq Feb 21, 2023
@grst grst added this to the 2.2.0 milestone Feb 21, 2023
@grst grst self-assigned this Oct 26, 2023
@grst
Copy link
Member

grst commented Oct 30, 2023

Fixed in dev. The default protocol is now "auto" for 10x.

@grst grst closed this as completed Oct 30, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in scrnaseq Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

3 participants