Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all file path parameters #199

Closed
Tracked by #200
sofstam opened this issue Dec 16, 2022 · 3 comments · Fixed by #206
Closed
Tracked by #200

Add all file path parameters #199

sofstam opened this issue Dec 16, 2022 · 3 comments · Fixed by #206
Assignees
Labels
enhancement Improvement for existing functionality

Comments

@sofstam
Copy link
Collaborator

sofstam commented Dec 16, 2022

Description of feature

Going through all ToDos before first-release, it would be good to add all file path parameters for the pipeline to the list below:

// TODO nf-core: Add all file path parameters for the pipeline to the list below
// Check input path parameters to see if they exist
def checkPathParamList = [ params.input, params.databases, params.hostremoval_reference,
params.shortread_hostremoval_index, params.multiqc_config,
params.shortread_qc_adapterlist
]

@sofstam sofstam added the enhancement Improvement for existing functionality label Dec 16, 2022
@sofstam sofstam mentioned this issue Dec 16, 2022
5 tasks
@jfy133 jfy133 added this to the First Release milestone Dec 20, 2022
@jfy133 jfy133 assigned jfy133 and sofstam and unassigned jfy133 Dec 20, 2022
@sofstam sofstam mentioned this issue Dec 23, 2022
9 tasks
@sofstam
Copy link
Collaborator Author

sofstam commented Dec 23, 2022

Are multiqc_title, multiqc_logo and multiqc_methods_description path parameters?

@jfy133
Copy link
Member

jfy133 commented Dec 23, 2022

logo and methods description is, but these aren't critical

@jfy133
Copy link
Member

jfy133 commented Dec 23, 2022

I'll add them anyway now as I had to do a small bug fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement for existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants