Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current UNTAR scheme inefficent and can cause overwriting for database sheet input #462

Closed
jfy133 opened this issue Mar 21, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@jfy133
Copy link
Member

jfy133 commented Mar 21, 2024

Description of the bug

Currently we 'blindly' untar every row in the database samplesheet. If someone has submitted the same database but with different parameters, we will untar that database repeatedly. If we go to publish this, we we will repeatedly overwrite the same files - the latter causes an error with strict

We should improve the efficiency of untarring to only do it once per file - so likely we have to group by file name, untar, then spread again with the metas to separate the differnet parameters.

Picked up by setting nextflow.enabled.strict = true in test config and running the test_malt profile

Command used and terminal output

No response

Relevant files

No response

System information

No response

@jfy133 jfy133 added the bug Something isn't working label Mar 21, 2024
@jfy133
Copy link
Member Author

jfy133 commented Apr 5, 2024

#461 done

@jfy133 jfy133 closed this as completed Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant