Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plant Growth Package] Rework critical and non-critical terms #65

Open
HLWeil opened this issue Nov 15, 2024 · 4 comments
Open

[Plant Growth Package] Rework critical and non-critical terms #65

HLWeil opened this issue Nov 15, 2024 · 4 comments
Labels
Status: Needs Triage This item is up for investigation.

Comments

@HLWeil
Copy link
Member

HLWeil commented Nov 15, 2024

The checked terms in the plant growth validation package are the ones from the plant growth condition template.

Now the question is which should be critical (required) and which should be non-critical? For the first version I based it on some ARCs but this is pretty arbitrary atm.

Any ideas or people to include in the discussion? @Brilator

@github-actions github-actions bot added the Status: Needs Triage This item is up for investigation. label Nov 15, 2024
@Brilator
Copy link
Member

The Plant_growth_conditions.xlsx template is the oldest template – from a time when we still had a very different to null understanding and tooling how metadata comes together :D (ontologies, swate, public repositories, etc.). I would not generally recommend to use this as a validation show-case.

which should be critical (required) and which should be non-critical

I'd recommend that we as DataPLANT do not reinvent those checklists of what is required / optional, but rather build this based on existing templates from communities / repositories

Maybe, Swate-templates/templates/dataplant/ArrayExpress_-_Plant_sample.xlsx or Swate-templates/templates/dataplant/ENA/ENA_-_Plant_sample_-_extension.xlsx would be better examples and already have requirements.

I'm sure @StellaEggels can add to this.

@StellaEggels
Copy link

We did update the plant growth conditions templates not too long ago, but I agree that for defining required/optional terms it would make sense to base it on the repositories' definitions. ENA- Plant sample contains the required terms, ENA-Plant sample- extension, the recommended ones.

@HLWeil
Copy link
Member Author

HLWeil commented Nov 20, 2024

Yeah it probably makes more sense to have hard contraints only for end-point specific validation packages.

But IMO we should we still keep generic validation packages with mostly recommended terms around to encourage users to share some terms they could otherwise have forgotten about.

@HLWeil HLWeil changed the title [Plant Growth Package] Rework critical and non-critical packages [Plant Growth Package] Rework critical and non-critical terms Nov 20, 2024
@Brilator
Copy link
Member

Add to yaml: First critical term is, whether a protocol type "plant growth protocol" exists

|> Seq.exists (fun token -> 
    token.Name = "ProtocolType" 
    && 
    //Param.getValueAsTerm token = (CvTerm.create("DPBO:1000164","plant growth protocol","DPBO"))
    (Param.getValueAsTerm token).Name = "plant growth protocol"
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage This item is up for investigation.
Projects
Status: No status
Development

No branches or pull requests

3 participants