Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose onScriptRequestStarted and onScriptError callbacks via props #87

Open
AlexisGlez opened this issue Sep 5, 2018 · 0 comments
Open

Comments

@AlexisGlez
Copy link

Description

It would be cool and really helpful if the Bling component can receive the props onScriptRequestStarted and onScriptError so the users can get these callbacks in their application.

Use Case Example

If we wrap this component with another one to display a progress bar while the ad is being requested, we can simplify the logic in our application to replace the progress bar with another thing if an error occurred.

Implementation Suggestion

The implementation for this would be really simple, in the Bling's componentDidMount we would call this.props.onScriptRequestStarted() method and in the function onScriptError we would call this.props.onScriptError()

Note: Maybe the callbacks can have a different name 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant