build_db removes table (and indexes and types etc) when it should just truncate

[tanho63]

The code from here: https://github.com/mrcaseb/nflfastR/blob/master/R/helper_database_functions.R#L119:L123 removes the table (I think so that it's more efficient to send whole tables of data) - it unfortunately also removes any column types and indexes, which was giving me trouble yesterday since it was specifying odd column types.

I believe replacing

dbRemoveTable(db_conn, tblname)

with

DBI::dbExecute(db_conn, glue::glue("DELETE FROM {tblname}"))

would resolve the issue - this only removes rows and not the actual table/indexes/columntypes.

[mrcaseb]

Thanks for the suggestion @tanho63! I will most likely implement this. However, it can take a few days because I think this is also a solution for another problem I was thinking about.

[mrcaseb]

@tanho63 I just linked a PR in which I have implemented two things:

1. No longer remove the tables but only the rows within the tables
2. Based on 1 it should now be possible to rebuild specified seasons

I'd be very thankful if you could check if this stuff is working in your db as we are only using SQLite dbs (and I hope it is working there, lol).

[tanho63]

Will tinker this weekend :)

[mrcaseb]

No worries. I've merged it in because we want to use the function but I still have in mind we might have to fix some stuff.