Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2020_10_DEN_LV PID: 979 Successful Fourth Down Conversion on Play with a Holding #218

Closed
JoeMarino2021 opened this issue Mar 11, 2021 · 3 comments · Fixed by #222
Closed

Comments

@JoeMarino2021
Copy link

On the first play of the second quarter Vegas lined up to try a 4th and 1 from Denver's 30.

PID QTR SIT DESC
979 2 LV-4-1-DEN 30 (15:00) J.Jacobs right guard to DEN 29 for 1 yard (B.Chubb). PENALTY on LV-B.Parker, Offensive Holding, 10 yards, enforced at DEN 30 - No Play.

This play has the "fourth_down_converted" flag set to 1. It should be set to 0. Vegas would go on to punt on the subsequent 4th and 11 after their holding.

Thanks again for everything! Keep up the tremendous work!

@guga31bb guga31bb linked a pull request Mar 15, 2021 that will close this issue
@JoeMarino2021
Copy link
Author

Instead of hard coding this play to correct it (which would allow for the root cause to create the error again), would it not be better to note that the following play was also a fourth down? Also, if a 4th down is successful, shouldn't a TD be scored or a first down earned? Looking at the play description for a "TOUCHDOWN" or at the next play for a first down should better resolve this issue, no?

Thanks for all of the quick work on these issues!

@mrcaseb
Copy link
Member

mrcaseb commented Mar 15, 2021

The root cause of the problem are the score keepers of the NFL. It's in the underlying data. There is nothing we can do to prevent this. It simply shouldn't happen on the NFL's part.

@JoeMarino2021
Copy link
Author

Oh. OK. So if the nflfastR code will work on correct NFL data, then never mind. We can only hope for the NFL to get it right in the future. We can't do their job for them.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants