Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curious occurrences of N/A EPA #22

Closed
TheMathNinja opened this issue Jun 21, 2020 · 8 comments
Closed

Curious occurrences of N/A EPA #22

TheMathNinja opened this issue Jun 21, 2020 · 8 comments

Comments

@TheMathNinja
Copy link
Contributor

I'm not quite sure why these plays have "NA" for epa variable:

game_id 2017_03_CIN_GB
play_id 1149 and 1173

game_id 2015_14_PIT_CIN
play_id 2089

@guga31bb
Copy link
Member

Thanks! This appears to be yet another issue caused by NFL providing plays out of order:

  quarter_seconds_remai~ desc                                                           ep     epa
                   <dbl> <chr>                                                       <dbl>   <dbl>
1                    900 9-C.Boswell kicks 65 yards from PIT 35 to end zone, Touch~  0.973  0     
2                    900 (15:00) (Shotgun) 5-A.McCarron pass short right to 32-J.H~  0.973 NA     
3                    850 9-C.Boswell extra point is GOOD, Center-60-G.Warren, Hold~  0.931  0.0685
4                    850 (14:10) (Shotgun) 5-A.McCarron pass short left intended f~ NA     NA     
5                    850 9-C.Boswell kicks 75 yards from PIT 20 to CIN 5. 19-B.Tat~  0.973  0.900

@guga31bb
Copy link
Member

This was caused by NFL not providing drive on the PAT following defensive TDs and has been fixed. Thanks for catching all of these! Finally starting the re-scrape and then the data will reflect all these updates

@guga31bb
Copy link
Member

Ok data in the data repo have been updated- please let us know if anything else doesn't look right!

@TheMathNinja
Copy link
Contributor Author

I think something went wrong with the re-scrape. All of a sudden, my fumble and interception coefficients for EPA are somewhat negligible (i.e. -0.5 instead -3).

@guga31bb
Copy link
Member

Yep you're right. Sigh.

@guga31bb
Copy link
Member

Was a bug induced by putting the plays in the right order. Re-scraping now...

@guga31bb guga31bb reopened this Jun 22, 2020
@guga31bb
Copy link
Member

Ok it is hopefully fixed now, please let us know how it looks!

@TheMathNinja
Copy link
Contributor Author

Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants