Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix season_type for extended regular season #242

Closed
mrcaseb opened this issue Apr 18, 2021 · 0 comments · Fixed by #241
Closed

Fix season_type for extended regular season #242

mrcaseb opened this issue Apr 18, 2021 · 0 comments · Fixed by #241

Comments

@mrcaseb
Copy link
Member

mrcaseb commented Apr 18, 2021

It looks like the extended reg season only affects this line

season_type <- dplyr::if_else(week <= 17, "REG", "POST")

as well as parts of the beginners guide vignette

filter(week <= 17, !is.na(epa)) %>%

filter(rush == 1 | pass == 1, week <= 17, !is.na(epa), !is.na(posteam), posteam != "") %>%

Although the examples in the beginners guide use seasons where it is safe to filter week, I think it's better to use season_type so people learn to work with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant