Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pbp.. Kick_distance #392

Closed
Cityviewsound opened this issue Oct 25, 2022 · 2 comments · Fixed by #421
Closed

pbp.. Kick_distance #392

Cityviewsound opened this issue Oct 25, 2022 · 2 comments · Fixed by #421

Comments

@Cityviewsound
Copy link

In PBP.. Kick_Distance only shows a value when the kickoff is not a touchback. please show a value for all kickoffs. If the kickoff starts On the 35, and the kick is a touchback, the kick distance would be 50 yards.
@tanho63 tanho63 transferred this issue from nflverse/nflverse Oct 25, 2022
@tanho63 tanho63 mentioned this issue Oct 25, 2022
Closed
2 tasks
@tanho63
Copy link
Member

tanho63 commented Oct 25, 2022

Related to #53-ish.

@mrcaseb mrcaseb mentioned this issue Aug 30, 2023
Merged
@mrcaseb
Copy link
Member

mrcaseb commented Aug 31, 2023

For future reference: final fix of this issue happened in #422 by using the corresponding stat IDs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fill kick_distance on kickoffs and punts resulting in touchbacks nflverse/nflfastR
3 participants
@tanho63 @mrcaseb @Cityviewsound