Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support transforming arc commands #9

Merged
merged 2 commits into from
Jan 13, 2016
Merged

Conversation

rhendric
Copy link
Collaborator

This fixes an issue where most non-trivial transformations were not being correctly applied to arcs. The endpoints would move but the arc radii and rotation angle would remain unchanged, resulting in an incorrect final path. Test cases illustrate some of the ways this failed previously.

I left a lot of algebra in the comments, which hopefully sheds light on how the transformation works. I can trim it down if you think the math is too obvious (or add more English if the math isn't obvious enough).

@nfroidure
Copy link
Owner

I appreciate you contribution but too much math for me to review it quickly (before i actually deep dive into shapes and matrix transformations).

Let's be confident into your work. I'll merge and publish your changes once the travis build will be repaired in order to get them passing. I'll work on it asap.

Thanks again for your contribution.

nfroidure added a commit that referenced this pull request Jan 13, 2016
Support transforming arc commands
@nfroidure nfroidure merged commit 8e7c65c into nfroidure:master Jan 13, 2016
@nfroidure
Copy link
Owner

Thanks for your valuable contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants