fix(module:sf): shoule trigger detect change when reset value (#332)

- close ng-alain/ng-alain#831
ng-alain · Dec 21, 2018 · ffd365b · ffd365b
1 parent 6c8c2d1
commit ffd365b
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 3 deletions.
diff --git a/packages/form/spec/base.spec.ts b/packages/form/spec/base.spec.ts
@@ -111,11 +111,14 @@ export class SFPage {
     return path.startsWith('/') ? path : '/' + path;
   }
 
+  getValue(path: string): any {
+    path = this.fixPath(path);
+    return this.comp.getValue(path);
+  }
+
   setValue(path: string, value: any): this {
     path = this.fixPath(path);
-    const property = this.comp.rootProperty.searchProperty(path);
-    expect(property).not.toBeNull(`can't found ${path}`);
-    property.widget.setValue(value);
+    this.comp.setValue(path, value);
     return this;
   }
 

diff --git a/packages/form/src/widgets/date/date.widget.spec.ts b/packages/form/src/widgets/date/date.widget.spec.ts
@@ -57,6 +57,15 @@ describe('form: widget: date', () => {
         expect(format(comp.value)).toBe(format(time));
       });
     });
+    it('should be set value', () => {
+      const s: SFSchema = {
+        properties: { a: { type: 'string', format: 'date-time', ui: { widget } } },
+      };
+      page.newSchema(s)
+          .checkValue('a', null)
+          .setValue('a', new Date());
+      expect(page.getValue('a') instanceof Date).toBe(true);
+    });
   });
 
   describe('#mode', () => {

diff --git a/packages/form/src/widgets/date/date.widget.ts b/packages/form/src/widgets/date/date.widget.ts
@@ -46,13 +46,19 @@ export class DateWidget extends ControlWidget implements OnInit {
     };
   }
 
+  private compCd() {
+    // TODO: removed after nz-datepick support OnPush mode
+    setTimeout(() => this.detectChanges());
+  }
+
   reset(value: SFValue) {
     value = this.toDate(value);
     if (this.flatRange) {
       this.displayValue = value == null ? [] : [value, this.toDate(this.endProperty.formData)];
     } else {
       this.displayValue = value;
     }
+    this.compCd();
   }
 
   _change(value: Date | Date[]) {

diff --git a/packages/form/src/widgets/time/time.widget.ts b/packages/form/src/widgets/time/time.widget.ts
@@ -57,9 +57,15 @@ export class TimeWidget extends ControlWidget implements OnInit {
     };
   }
 
+  private compCd() {
+    // TODO: removed after nz-datepick support OnPush mode
+    setTimeout(() => this.detectChanges());
+  }
+
   reset(value: SFValue) {
     if (value instanceof Date) {
       this.displayValue = value;
+      this.compCd();
       return;
     }
     let v = value != null && value.toString().length ? new Date(value) : null;
@@ -70,6 +76,7 @@ export class TimeWidget extends ControlWidget implements OnInit {
       v = new Date(`1970-1-1 ` + value);
     }
     this.displayValue = v;
+    this.compCd();
   }
 
   _change(value: Date) {