Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(abc:st): add i18n in pop #1874

Merged
merged 1 commit into from
Jan 19, 2025
Merged

feat(abc:st): add i18n in pop #1874

merged 1 commit into from
Jan 19, 2025

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Jan 19, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@cipchk
Copy link
Member Author

cipchk commented Jan 19, 2025

Preview is ready!

@cipchk cipchk changed the title feat(abc:st): feat i18n of pop feat(abc:st): add i18n in pop Jan 19, 2025
Copy link

codecov bot commented Jan 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.00%. Comparing base (983cedb) to head (3ea328e).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1874   +/-   ##
=======================================
  Coverage   95.00%   95.00%           
=======================================
  Files         273      273           
  Lines        8845     8849    +4     
  Branches     1705     1709    +4     
=======================================
+ Hits         8403     8407    +4     
  Misses        364      364           
  Partials       78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cipchk cipchk merged commit f752c24 into master Jan 19, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 118n support to STColumnButtonPop
1 participant