fix(nav): don't emit (navChange) when activeId is not set initially (#…

…3567) Fixes #3564
ng-bootstrap · Feb 7, 2020 · dd1c35d · dd1c35d
1 parent f845951
commit dd1c35d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/nav/nav.spec.ts b/src/nav/nav.spec.ts
@@ -200,7 +200,7 @@ describe('nav', () => {
     expectLinks(fixture, [true, false]);
     expectContents(fixture, ['content 1']);
     expect(activeIdChangeSpy).toHaveBeenCalledWith(1);
-    expect(navChangeSpy).toHaveBeenCalledWith({activeId: undefined, nextId: 1, preventDefault: jasmine.any(Function)});
+    expect(navChangeSpy).toHaveBeenCalledTimes(0);
   });
 
   it(`should initially select nothing, if [activeId] provided is incorrect`, () => {

diff --git a/src/nav/nav.ts b/src/nav/nav.ts
@@ -201,7 +201,7 @@ export class NgbNav implements AfterContentInit {
     if (!isDefined(this.activeId)) {
       const nextId = this.items.first ? this.items.first.id : null;
       if (nextId) {
-        this._updateActiveId(nextId);
+        this._updateActiveId(nextId, false);
         this._cd.detectChanges();
       }
     }