New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rating): allow set rating to 0 on click #1515

Closed

maxokorokov wants to merge 1 commit into ng-bootstrap:master from maxokorokov:rating_reset_to_zero

Member

maxokorokov commented Apr 25, 2017

adds the resettable: boolean property to rating
if resettable === true then clicking on currently selected rating will reset it to 0

See my comment for details.

Fixes #1284


feat(rating): allow set rating to 0 on click

417272f

Fixes ng-bootstrap#1284

maxokorokov added component: rating needs: review labels

pkozlowski-opensource added this to the 1.0.0-alpha.26 milestone

Member

pkozlowski-opensource commented Apr 25, 2017

LGTM

pkozlowski-opensource closed this in

e3100e5

maxokorokov mentioned this pull request

Rating can't be set to zero. #1284

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment