fix(buttons): make buttons selectors more specific #1678
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxokorokov
reviewed
Jul 13, 2017
| @@ -57,8 +57,8 @@ export class NgbRadioGroup implements ControlValueAccessor { | |||
| } | |||
|
|
|||
|
|
|||
| @Directive({selector: 'label.btn'}) | |||
| export class NgbActiveLabel { | |||
| @Directive({selector: '[ngbButtonLabel]', host: {'[class.btn]': 'true'}}) | |||
There was a problem hiding this comment.
This would potentially overwrite classes that people would like to set on the <label> element, so I would prefer to leave it as-is.
BREAKING CHANGE:
Selectors for radio buttons related directives were changed and now both label
and input require ng-bootstrap specific attributes as selectors.
Before:
```
<div [(ngModel)]="model" ngbRadioGroup>
<label class="btn">
<input type="radio" name="radio" [value]="values[0]"/> {{ values[0] }}
</label>
<label class="btn">
<input type="radio" name="radio" [value]="values[1]"/> {{ values[1] }}
</label>
</div>
```
After:
```
<div [(ngModel)]="model" ngbRadioGroup>
<label ngbButtonLabel>
<input ngbButton type="radio" name="radio" [value]="values[0]"/> {{ values[0] }}
</label>
<label ngbButtonLabel>
<input ngbButton type="radio" name="radio" [value]="values[1]"/> {{ values[1] }}
</label>
</div>
```
Notice new `ngbButtonLabel` and `ngbButton` attributes that act as new selectors.
Fixes #1125
|
@maxokorokov thnx for the review - I've completely forgotten about the demo part!!! Pushed amended commit with the demo. Regarding renames - I'm going to open another PR with the checkbox buttons where (hopefully) the existing names will make more sense. Hold a sec. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
Selectors for radio buttons related directives were changed and now both label
and input require ng-bootstrap specific attributes as selectors.
Before:
After:
Notice new
ngbButtonLabelandngbButtonattributes that act as new selectors.Fixes #1125