Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(position): accept placement values with a space separated string #3034

Merged
merged 1 commit into from
Feb 21, 2019

Conversation

fbasso
Copy link
Member

@fbasso fbasso commented Feb 20, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Feb 20, 2019

Codecov Report

Merging #3034 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3034   +/-   ##
=======================================
  Coverage   92.36%   92.36%           
=======================================
  Files          91       91           
  Lines        2909     2909           
  Branches      468      468           
=======================================
  Hits         2687     2687           
  Misses        163      163           
  Partials       59       59
Flag Coverage Δ
#e2e 59.91% <100%> (ø) ⬆️
#unit 90.87% <100%> (ø) ⬆️
Impacted Files Coverage Δ
src/tooltip/tooltip.ts 98.46% <ø> (ø) ⬆️
src/typeahead/typeahead.ts 97.35% <ø> (ø) ⬆️
src/datepicker/datepicker-input.ts 97.1% <ø> (ø) ⬆️
src/popover/popover.ts 100% <ø> (ø) ⬆️
src/dropdown/dropdown.ts 98.31% <ø> (ø) ⬆️
src/util/positioning.ts 94.35% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be84733...75fd43a. Read the comment docs.

src/util/positioning.ts Outdated Show resolved Hide resolved
Copy link
Member

@maxokorokov maxokorokov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

We need to properly test positionElements as there is a lot of "magic" happening there, especially with CSS classes adding/removing. But out of scope of this PR I guess.

@maxokorokov maxokorokov added this to the 4.1 milestone Feb 21, 2019
@maxokorokov maxokorokov merged commit 28ce374 into ng-bootstrap:master Feb 21, 2019
@fbasso fbasso deleted the placement-string branch February 21, 2019 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants