Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toast): export NgbToastModule publicly #3259

Merged
merged 1 commit into from
Jun 28, 2019

Conversation

benouat
Copy link
Member

@benouat benouat commented Jun 28, 2019

Main export of NgbToastModule was missing, which basically prevented
people to write

import {NgbToastModule} from "@ng-bootstrap/ng-bootstrap";

Fixes #3258

Main export of NgbToastModule was missing, which basically prevented
people to write

```typescript
import {NgbToastModule} from "@ng-bootstrap/ng-bootstrap";
```

Fixes ng-bootstrap#3258
@codecov-io
Copy link

Codecov Report

Merging #3259 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3259   +/-   ##
=======================================
  Coverage   90.77%   90.77%           
=======================================
  Files          94       94           
  Lines        2711     2711           
  Branches      507      507           
=======================================
  Hits         2461     2461           
  Misses        190      190           
  Partials       60       60
Flag Coverage Δ
#e2e 55.18% <ø> (ø) ⬆️
#unit 87.89% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/index.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5bbe80...f3b32eb. Read the comment docs.

@benouat benouat added this to the 5.0.0-rc.1 milestone Jun 28, 2019
@benouat benouat merged commit 0d69682 into ng-bootstrap:master Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NgbToastModule should be exported from ng-bootstrap/index
2 participants