fix: accept spaces while tagging without dropdown

fixes #676
ng-select · Aug 8, 2018 · 4320098 · 4320098
1 parent 75e9ac2
commit 4320098
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/src/ng-select/items-list.spec.ts b/src/ng-select/items-list.spec.ts
@@ -356,6 +356,6 @@ function itemsList(cmp: NgSelectComponent): ItemsList {
 }
 
 function ngSelect(): NgSelectComponent {
-    const cmp = new NgSelectComponent({}, null, null, null, null);
+    const cmp = new NgSelectComponent({}, null, null, null, null, null);
     return cmp;
 }
diff --git a/src/ng-select/ng-select.component.spec.ts b/src/ng-select/ng-select.component.spec.ts
@@ -1021,9 +1021,11 @@ describe('NgSelectComponent', function () {
             });
 
             it('should not open dropdown when isOpen is false', () => {
+                const open = spyOn(select, 'open');
                 select.ngOnChanges(<any>{ isOpen: { currentValue: false }});
                 triggerKeyDownEvent(getNgSelectElement(fixture), KeyCode.Space);
                 expect(select.isOpen).toBeFalsy();
+                expect(open).not.toHaveBeenCalled();
             });
 
             it('should open empty dropdown if no items', fakeAsync(() => {
@@ -1848,7 +1850,7 @@ describe('NgSelectComponent', function () {
             }));
         }));
 
-        describe('Show add tag', () => {
+        describe('show add tag', () => {
             let select: NgSelectComponent;
             let fixture: ComponentFixture<NgSelectTestCmp>;
             beforeEach(() => {

diff --git a/src/ng-select/ng-select.component.ts b/src/ng-select/ng-select.component.ts
@@ -715,7 +715,7 @@ export class NgSelectComponent implements OnDestroy, OnChanges, AfterViewInit, C
     }
 
     private _handleSpace($event: KeyboardEvent) {
-        if (this.isOpen) {
+        if (this.isOpen || this._manualOpen) {
             return;
         }
         this.open();