Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: toggle dropdown when searchable is false. #137

Merged
merged 1 commit into from
Nov 26, 2017
Merged

feat: toggle dropdown when searchable is false. #137

merged 1 commit into from
Nov 26, 2017

Conversation

aitboudad
Copy link
Contributor

No description provided.

@anjmao anjmao self-requested a review November 26, 2017 10:03
anjmao
anjmao approved these changes Nov 26, 2017
View reviewed changes
Copy link
Member

@anjmao anjmao left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aitboudad Looks good, thanks :)

@anjmao anjmao merged commit 2477717 into ng-select:master Nov 26, 2017
@aitboudad aitboudad deleted the toggle branch November 26, 2017 10:10
@aitboudad
Copy link
Contributor Author

Thanks you too for the awesome work in this lib!

jakemdunn pushed a commit to jakemdunn/ng-select that referenced this pull request Oct 16, 2018
@aitboudad @anjmao
feat: toggle dropdown when searchable is false. (ng-select#137)
c9ba1d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anjmao anjmao anjmao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aitboudad @anjmao