Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(hideSelected): allow to open dropdown when tagging enabled #464

Merged
merged 2 commits into from
Apr 17, 2018
Merged

fix(hideSelected): allow to open dropdown when tagging enabled #464

merged 2 commits into from
Apr 17, 2018

Conversation

varnastadeus
Copy link
Member

fixes #457

@coveralls
Copy link

coveralls commented Apr 16, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.07%) to 93.409% when pulling c99d3b8 on hide-selected-fix into f5101d0 on master.

@anjmao anjmao merged commit 852643f into master Apr 17, 2018
@varnastadeus varnastadeus deleted the hide-selected-fix branch April 19, 2018 12:01
jakemdunn pushed a commit to jakemdunn/ng-select that referenced this pull request Oct 16, 2018
@varnastadeus @anjmao
fix(hideSelected): allow to open dropdown when tagging enabled (ng-se…
847cf57 
…lect#464)

fixes ng-select#457
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anjmao anjmao Awaiting requested review from anjmao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not possible to create custom options when using hideSelected and item array is empty or already selected
3 participants
@varnastadeus @coveralls @anjmao