Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Elasticsearch circle geo_shape objects #64

Closed
warwickdufour opened this issue Mar 12, 2018 · 3 comments
Closed

Support for Elasticsearch circle geo_shape objects #64

warwickdufour opened this issue Mar 12, 2018 · 3 comments

Comments

@warwickdufour
Copy link

I work in the field of visualising aviation data such as aerodromes, airspaces and airways. Recently I needed to visualise NOTAMs which, at their most basic, consist of a point and circle radius and as far as I know ElasticGeo does not support them.

I have cloned and modified ElasticGeo so that it does support them, albeit quite simplistically. If it is of interest I am happy to contribute my additions to the code base but as it has been a long time since I did so I would like some help with the whole 'pull request' process.

@sjudeng
Copy link
Contributor

sjudeng commented Mar 13, 2018

Sounds great. Thanks for thinking of contributing the feature. Here are some links on the PR process in general.

  1. Fork this project
  2. Add remote for your fork:
    git remote add warwickdufour https://github.com/warwickdufour/elasticgeo.git
  3. If you haven't already create a branch for your feature:
    git checkout -b circle
  4. Push your feature branch to your remote:
    git push warwickdufour circle
  5. Create pull request through the GitHub UI
  6. (If necessary) push updates to your branch based on pull request review feedback:
    git commit ...
    git push warwickdufour circle

@warwickdufour
Copy link
Author

Hi @sjudeng , taken me a while to get round to it I'm afraid but I'm just about to create a pull request. I'm presuming I should 'compare across forks' as per the attached image:
screenshot from 2018-04-04 14-04-09

@sjudeng
Copy link
Contributor

sjudeng commented Apr 23, 2018

Closed in #67

@sjudeng sjudeng closed this as completed Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants