fix(cesium): fix heightReference updates as classes

clampToGround is implemented on Polyline and Primitive (polygon) not as a
heightReference value but as separate classes (GroundPolylinePrimitive and
GroundPrimitive). Therefore, if the heightReference changes, we cannot
update those primitives and must instead recreate them.

Author: wallw-teal

src/os/ui/featureedit.js

@@ -1317,14 +1317,20 @@ os.ui.FeatureEditCtrl.prototype.saveGeometry_ = function(feature) {
         feature.set(os.style.StyleField.ROTATION_COLUMN, '', true);
       }
     }
-  } else if (this.originalGeometry) {
+  } else if (this.originalGeometry && feature.getGeometry() === this.originalGeometry) {
     feature.setGeometry(this.originalGeometry.clone());
   }
 
   var geom = feature.getGeometry();
+
   if (geom) {
-    os.ui.FeatureEditCtrl.setGeometryRecursive(geom, os.data.RecordField.ALTITUDE_MODE, this['altitudeMode'], true);
-    geom.changed();
+    var altMode = geom.get(os.data.RecordField.ALTITUDE_MODE);
+    altMode = Array.isArray(altMode) && altMode.length ? altMode[0] : altMode;
+
+    if (altMode !== this['altitudeMode']) {
+      os.ui.FeatureEditCtrl.setGeometryRecursive(geom, os.data.RecordField.ALTITUDE_MODE, this['altitudeMode'], true);
+      geom.changed();
+    }
   }
 };
 

src/plugin/cesium/sync/featureconverter.js

@@ -1779,6 +1779,15 @@ plugin.cesium.sync.FeatureConverter.prototype.olGeometryToCesium = function(feat
     return;
   }
 
+  var heightReference = this.getHeightReference(context.layer, feature, geometry);
+  if ((heightReference !== Cesium.HeightReference.CLAMP_TO_GROUND &&
+    (primitive instanceof Cesium.GroundPolylinePrimitive || primitive instanceof Cesium.GroundPrimitive)) ||
+    (heightReference === Cesium.HeightReference.CLAMP_TO_GROUND &&
+    (primitive instanceof Cesium.Polyline || primitive instanceof Cesium.Primitive))) {
+    // we cannot update it; it must be recreated
+    primitive = null;
+  }
+
   if (primitive && geomType != ol.geom.GeometryType.GEOMETRY_COLLECTION) {
     // already exists - update it
     this.updatePrimitiveLike(feature, geometry, style, context, primitive);