Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does this container take complete control of /etc/nginx/certs or can I add my own certs in addition to the generated LE certs? #476

Closed
benjamin-smith opened this issue Dec 1, 2018 · 4 comments
Labels
kind/bug Issue reporting a bug kind/question Issue that might be transferred to Discussions

Comments

@benjamin-smith
Copy link
Contributor

For the hosts I am using nginx-proxy for, I want one of the hosts to use a cert generated outside of this LE companion container. My use case is I need a wildcard cert, which I have generated separately. Mounting this from the host to the container works great and I am using the CERT_NAME env var.

After some time, the custom cert files are removed, and I suspect this container is overwriting those files. Note the filename does not match any host that this container is configured for with a LETSENCRYPT_HOST env var. Custom files are removed, not overwritten.

Is it possible to use this container alongside custom certs on the same nginx-proxy container? If not, is there some sort of known workaround for this use case.

Thanks!

@buchdag buchdag added kind/question Issue that might be transferred to Discussions kind/bug Issue reporting a bug labels Dec 13, 2018
@buchdag
Copy link
Member

buchdag commented Dec 15, 2018

After some time, the custom cert files are removed, and I suspect this container is overwriting those files. Note the filename does not match any host that this container is configured for with a LETSENCRYPT_HOST env var. Custom files are removed, not overwritten.

This should have been fixed recently (see #465 and #472).

Could you try again with an up to date version of the container ?

@buchdag
Copy link
Member

buchdag commented Mar 12, 2019

Closing due to inactivity.

@buchdag buchdag closed this as completed Mar 12, 2019
@benjamin-smith
Copy link
Contributor Author

Apologies for not circling back - yes this was resolved in the fixes as you mentioned. Thank you!

@buchdag
Copy link
Member

buchdag commented Mar 12, 2019

Glad it works OK for you now, there is no need to apologise 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Issue reporting a bug kind/question Issue that might be transferred to Discussions
Projects
None yet
Development

No branches or pull requests

2 participants