Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing email #638

Closed
Phelic2k opened this issue Mar 20, 2020 · 4 comments · Fixed by #719
Closed

Missing email #638

Phelic2k opened this issue Mar 20, 2020 · 4 comments · Fixed by #719
Assignees
Labels
kind/bug Issue reporting a bug

Comments

@Phelic2k
Copy link

Phelic2k commented Mar 20, 2020

This is an awesome project!
Right now I am getting an error when a new certificate is created:

simp_le: error: argument --email: expected one argument

Shouldn't the "DEFAULT_EMAIL" be enough here?

My docker-compose.yml:

version: '2'
services:
  frontproxy:
    build: ./frontproxy
    hostname: frontproxy
    restart: always
    container_name: frontproxy
    environment:
        DEFAULT_HOST: testvhost.local
        ENABLE_IPV6: "true"
        NETWORK_ACCESS: internal
    ports:
      - "80:80"
      - "443:443
    volumes:
      - /var/run/docker.sock:/tmp/docker.sock:ro
      - /etc/nginx/certs:/etc/nginx/certs:ro
      - /etc/nginx/conf.d:/etc/nginx/conf.d
      - /etc/nginx/dhparam:/etc/nginx/dhparam
      - /etc/nginx/vhost.d:/etc/nginx/vhost.d
      - /usr/share/nginx/html:/usr/share/nginx/html
  frontproxyssl:
    build: ./frontproxyssl
    container_name: frontproxyssl
    hostname: frontproxyssl
    restart: always
    depends_on:
      - frontproxy
    environment:
      - DEFAULT_EMAIL=user@domain.tld
    volumes_from:
      - frontproxy
    volumes:
      - /etc/nginx/certs:/etc/nginx/certs:rw
      - /var/run/docker.sock:/var/run/docker.sock:ro

The according Dockerfile:
FROM jrcs/letsencrypt-nginx-proxy-companion:latest

EDIT:
the environment variable LETSENCRYPT_EMAIL in my project overrode the setting

@buchdag buchdag added the kind/bug Issue reporting a bug label Mar 20, 2020
@buchdag
Copy link
Member

buchdag commented Mar 20, 2020

That might be considered a bug, but I have no idea yet how we should treat *_EMAIL environment variables priority

@buchdag buchdag reopened this Mar 20, 2020
@Phelic2k
Copy link
Author

sorry, that was my fault.
Everything is working as expected. The project's settings should overrride the default.

@buchdag
Copy link
Member

buchdag commented Mar 21, 2020

The project's settings should overrride the default.

That would make sense to me too, unfortunately that would also require a complete re-work of the way accounts are handled internally.

@buchdag buchdag self-assigned this May 11, 2020
@buchdag
Copy link
Member

buchdag commented Jul 15, 2020

@Phelic2k getting back to you on this one, if I understand the issue correctly you had an empty LETSENCRYPT_EMAIL environment variable in your project that overrode the DEFAULT_EMAIL ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Issue reporting a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants