Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate GEP on Session Persistence #1670

Closed
mpstefan opened this issue Mar 12, 2024 · 1 comment
Closed

Evaluate GEP on Session Persistence #1670

mpstefan opened this issue Mar 12, 2024 · 1 comment
Assignees
Labels
chore Pull requests for routine tasks refined Requirements are refined and the issue is ready to be implemented.
Milestone

Comments

@mpstefan
Copy link
Collaborator

mpstefan commented Mar 12, 2024

We need to evaluate the following GEP in the Gateway API to determine its feasibility as written:

kubernetes-sigs/gateway-api#2634

Acceptance

  • The above GEP is evaluated to determine if the new functionality present is feasibly implementable by NGINX.
  • The GEP has a review added explaining the results of the evaluation, including any improvements necessary to support NGINX, if applicable.
@mpstefan mpstefan added the chore Pull requests for routine tasks label Mar 12, 2024
@mpstefan mpstefan added this to the v1.3.0 milestone Mar 12, 2024
@mpstefan mpstefan added the refined Requirements are refined and the issue is ready to be implemented. label Mar 12, 2024
@sjberman sjberman changed the title Evalutate GEP on Session Persistence Evaluate GEP on Session Persistence Apr 3, 2024
@sjberman sjberman self-assigned this Apr 4, 2024
@sjberman
Copy link
Collaborator

sjberman commented Apr 4, 2024

Reviewed the GEP (which was merged by the time I started on this), but overall things look good in terms of NGINX support.

NGINX Plus supports session persistence using the sticky directive. It appears that OSS also may support session persistence, but it's basic and doesn't allow for configuring parameters like time, path, security, etc. So this appears to be a Plus-only feature, at least for the proposed API.

We may not be able to support the SessionName field in the proposed API, but it's considered extended support. Also not sure if we can support header-based persistence (maybe using sticky learn?), but that's also considered extended.

There could be overlap at some point with this proposed BackendLBPolicy and our proposed UpstreamSettingsPolicy, so we may have to reconcile those two in some way...this can be decided at implementation-time.

@sjberman sjberman closed this as completed Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks refined Requirements are refined and the issue is ready to be implemented.
Projects
None yet
Development

No branches or pull requests

2 participants