Skip to content

Functional Test for SnippetsFilter #2371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mpstefan opened this issue Aug 12, 2024 · 1 comment
Closed

Functional Test for SnippetsFilter #2371

mpstefan opened this issue Aug 12, 2024 · 1 comment
Assignees
@salonichf5
Labels
refined Requirements are refined and the issue is ready to be implemented. size/medium Estimated to be completed within a week tests Pull requests that update tests
Milestone
v1.5.0

Comments

@mpstefan
Copy link
Member

mpstefan commented Aug 12, 2024 •
edited
Loading

As a maintainer of NGF
I want a functional test to cover the SnippetsFilter
So that I can verify that NGF is correctly interpreting the SnippetsFilter into NGINX configuration.

Acceptance

  • The functional test should verify that:
    • The configuration specified in the SnippetsFilter is applied to the correct place in the NGINX configuration.
    • ...
@mpstefan mpstefan mentioned this issue Aug 12, 2024
Closed
@mpstefan mpstefan added the tests Pull requests that update tests label Aug 12, 2024
@mpstefan mpstefan added this to the v1.5.0 milestone Aug 12, 2024
@mpstefan mpstefan added the blocked Blocked by other issue label Sep 3, 2024
@mpstefan
Copy link
Member Author

mpstefan commented Sep 3, 2024

Not technically blocked, but we want to do #2014 first.

@mpstefan mpstefan added refined Requirements are refined and the issue is ready to be implemented. size/medium Estimated to be completed within a week labels Sep 3, 2024
@sindhushiv sindhushiv removed the blocked Blocked by other issue label Sep 26, 2024
@salonichf5 salonichf5 self-assigned this Oct 2, 2024
@salonichf5 salonichf5 mentioned this issue Oct 8, 2024
Merged
6 tasks
@sjberman sjberman closed this as completed Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@salonichf5 salonichf5

Labels
refined Requirements are refined and the issue is ready to be implemented. size/medium Estimated to be completed within a week tests Pull requests that update tests
Projects
None yet
Milestone
v1.5.0
Development

No branches or pull requests
4 participants
@mpstefan @sindhushiv @sjberman @salonichf5