Skip to content

Unit tests when ran together do not provide helpful information upon failure #2584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bjee19 opened this issue Sep 19, 2024 · 1 comment · Fixed by #2613
Closed

Unit tests when ran together do not provide helpful information upon failure #2584

bjee19 opened this issue Sep 19, 2024 · 1 comment · Fixed by #2613
Assignees
Labels
bug Something isn't working tests Pull requests that update tests
Milestone

Comments

@bjee19
Copy link
Contributor

bjee19 commented Sep 19, 2024

When running unit tests together, like through the make unit-test command, the failure is difficult to find. The summary of the test results do not contain any information on which test(s) failed. For example:

There were failures detected in the following suites:
  config ./internal/mode/static/nginx/config

Test Suite Failed
exit status 1
make: *** [unit-test] Error 1

Although logs are printed, these are difficult to parse as they are extremely lengthy. The test failure is buried in this output and is hard to find.

=== NAME  TestExecuteMainIncludesConfig/complete_configuration
    main_includes_test.go:67: 
        Expected
            <int>: 1
        to equal
            <int>: 0

Examples:

Acceptance Criteria:

  • Name of failed test is printed in an easy to find location
  • Stack trace is printed (if possible)

Dev Notes:

  • Issue started to occur when we started running all our unit tests with ginkgo. Can we just run our ginkgo tests using ginkgo and the rest of our tests with go test?
  • Running the tests in parallel has made fixing this issue more of a priority.
@kate-osborn kate-osborn added the bug Something isn't working label Sep 24, 2024
@kate-osborn kate-osborn added this to the v1.5.0 milestone Sep 24, 2024
@kate-osborn kate-osborn added the tests Pull requests that update tests label Sep 24, 2024
@lucacome
Copy link
Contributor

Opened onsi/ginkgo#1461

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tests Pull requests that update tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants