Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace test logger with logr.Discard() #3041

Closed
sjberman opened this issue Jan 21, 2025 · 1 comment · Fixed by #3083
Closed

Replace test logger with logr.Discard() #3041

sjberman opened this issue Jan 21, 2025 · 1 comment · Fixed by #3083
Labels
good first issue Good for newcomers stale Pull requests/issues with no activity tech-debt Short-term pain, long-term benefit

Comments

@sjberman
Copy link
Collaborator

Our unit tests instantiate a new logger instance using the zap library when creating various objects. Instead, we can use logr.Discard() to create a logger that discards all logs for unit tests.

Acceptance

  • replace unit test loggers with logr.Discard()
Copy link
Contributor

github-actions bot commented Feb 5, 2025

This issue is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale Pull requests/issues with no activity label Feb 5, 2025
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers stale Pull requests/issues with no activity tech-debt Short-term pain, long-term benefit
Projects
Status: Done
1 participant