Review: Add default case to all select block

The default case will throw an error of the failure

Author: mrajagopal

pkg/jobs/common_job_list_test.go

@@ -53,6 +53,10 @@ func TestCommonJobList_SelectedJobsProduceFiles(t *testing.T) {
 			}
 		case <-ctx.Done():
 			t.Fatalf("job %s timed out", job.Name)
+
+		default:
+			// No result yet, which is unexpected since we set a timeout above
+			t.Fatalf("job %s did not return result", job.Name)
 		}
 	}
 }

pkg/jobs/ngx_job_list_test.go

@@ -73,6 +73,9 @@ func TestNGXJobList_ExecNginxT(t *testing.T) {
 		}
 	case <-time.After(time.Second):
 		t.Fatal("job execution timed out")
+
+	default:
+		t.Fatalf("job %s did not return result", job.Name)
 	}
 }
 

pkg/jobs/nic_job_list_test.go

@@ -69,6 +69,9 @@ func TestNICJobList_ExecJobs(t *testing.T) {
 			}
 		case <-time.After(time.Second):
 			t.Errorf("Job %s timed out", job.Name)
+
+		default:
+			t.Errorf("Job %s did not return result", job.Name)
 		}
 	}
 }
@@ -101,6 +104,9 @@ func TestNICJobList_CRDObjects(t *testing.T) {
 				}
 			case <-time.After(time.Second):
 				t.Errorf("CRD job timed out")
+
+			default:
+				t.Errorf("CRD job %s did not return result", job.Name)
 			}
 		}
 	}
@@ -180,6 +186,9 @@ func TestNICJobList_CRDObjects_QueryFailure(t *testing.T) {
 
 	case <-ctx.Done():
 		t.Fatal("CRD job timed out")
+
+	default:
+		t.Fatalf("CRD job %s did not return result", crdJob.Name)
 	}
 }
 
@@ -488,6 +497,9 @@ func TestNICJobList_CommandExecutionFailure(t *testing.T) {
 
 			case <-ctx.Done():
 				t.Fatalf("Job %s timed out", tt.jobName)
+
+			default:
+				t.Fatalf("Job %s did not return result", tt.jobName)
 			}
 		})
 	}
@@ -554,5 +566,8 @@ func TestNICJobList_CollectProductPlatformInfo_JSONMarshalFailure(t *testing.T)
 
 	case <-ctx.Done():
 		t.Fatal("Job timed out")
+
+	default:
+		t.Fatalf("Job %s did not return result", job.Name)
 	}
 }

pkg/jobs/nim_job_list_test.go

@@ -103,6 +103,9 @@ func TestNIMJobList_ExecJobs(t *testing.T) {
 			}
 		case <-time.After(2 * time.Second):
 			t.Errorf("Job %s timed out", job.Name)
+
+		default:
+			t.Errorf("Job %s did not return result", job.Name)
 		}
 	}
 }
@@ -135,6 +138,9 @@ func TestNIMJobList_ExcludeFlags(t *testing.T) {
 				}
 			case <-time.After(time.Second):
 				t.Fatal("Job exec-clickhouse-data timed out")
+
+			default:
+				t.Fatalf("Job %s did not return result", job.Name)
 			}
 		}
 	}
@@ -152,6 +158,9 @@ func TestNIMJobList_ExcludeFlags(t *testing.T) {
 				}
 			case <-time.After(time.Second):
 				t.Fatal("Job exec-dqlite-dump timed out")
+
+			default:
+				t.Fatalf("Job %s did not return result", job.Name)
 			}
 		}
 	}