Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Upgrade Hyper version. #1245

Open
Tracked by #1276
avahahn opened this issue May 3, 2024 · 0 comments
Open
Tracked by #1276

CLI: Upgrade Hyper version. #1245

avahahn opened this issue May 3, 2024 · 0 comments

Comments

@avahahn
Copy link
Contributor

avahahn commented May 3, 2024

The Bollard library we use to integrate with docker leverages Hyper v1.
The OpenAPI client code we have (both unit-openapi and in unit-client-sdk) leverages Hyper v0.
We currently include both at build time, which leads to more space used and longer builds.

From #1241:

Regrettably for NOW we do need both versions. The good news is that the last version of v0 is fairly recent and I get the impression it is still being supported inline with v1. We should make it a priority to migrate to the newest version of Hyper when the openapi generator supports it. In the meantime we will have some extra build dependencies.

Further reading: https://hyper.rs/guides/1/upgrading/

NOTE: We are currently blocked on waiting for the OpenAPI generator to support the latest Hyper:
OpenAPITools/openapi-generator#17876

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📖 Backlog
Development

No branches or pull requests

1 participant