Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Refactor custom error structures #1246

Open
Tracked by #1276
avahahn opened this issue May 3, 2024 · 0 comments
Open
Tracked by #1276

CLI: Refactor custom error structures #1246

avahahn opened this issue May 3, 2024 · 0 comments
Assignees

Comments

@avahahn
Copy link
Contributor

avahahn commented May 3, 2024

Currently both unit-client-rs and unitctl use a custom error crate that is not only superfluous but also hard to read. It is reducing overall code quality. Removing it and implementing a non-external solution would lead to quicker, smaller builds and more readable code.

Unitctl (bearable): https://github.com/nginx/unit/blob/master/tools/unitctl/unitctl/src/unitctl_error.rs
Unit-client-rs (abject disaster): https://github.com/nginx/unit/blob/master/tools/unitctl/unit-client-rs/src/unit_client.rs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 💪 In Development
Development

No branches or pull requests

2 participants