Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: deploy configuration to many instances #1318

Closed
Tracked by #1276
ava-affine opened this issue Jun 14, 2024 · 3 comments · Fixed by #1350
Closed
Tracked by #1276

CLI: deploy configuration to many instances #1318

ava-affine opened this issue Jun 14, 2024 · 3 comments · Fixed by #1350

Comments

@ava-affine
Copy link

unitctl import and unitctl execute should be able to send configuration snippets to a configurable list of Unit instances. Currently when multiple Unit instances exist on a host unitctl will ask for clarification on which control socket/endpoint to use. This should be extended to support a list. Under no circumstances should unitctl automatically broadcast to many Unit instances without a specific invocation from the user.

@lcrilly
Copy link
Contributor

lcrilly commented Jun 17, 2024

Does this apply to multiple instances on the host where unitctl is executed, or to multiple instances over a network?

@avahahn
Copy link
Contributor

avahahn commented Jun 17, 2024

It should apply for any control socket that unitctl can reach.
At the moment unitctl knows how to access control sockets over TCP and via a file socket.
If the user sets up some number of proxies for instances over the network then we shouldn't refuse to operate on them.

@avahahn
Copy link
Contributor

avahahn commented Jun 24, 2024

Just want to drop a quick note here on implementation:

Currently the CLI has a global flag for specifying a control socket when there are multiple Unit instances detected. This needs to be refactored to accept either a single socket or a list of sockets.

Additionally, code will be needed in main.rs to apply the specified cli command to each provided control socket. Perhaps socket should be an argument to each command in the cmd submodule. Existing commands should be checked to make sure that they arent manually handling the control socket flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants