Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Websocket upstream for VirtualServer #623

Closed
trungdq88 opened this issue Jul 16, 2019 · 2 comments
Closed

Support Websocket upstream for VirtualServer #623

trungdq88 opened this issue Jul 16, 2019 · 2 comments
Labels
proposal An issue that proposes a feature request

Comments

@trungdq88
Copy link

Is your feature request related to a problem? Please describe.
Currently, I can not define a WebSocket upstream with VirtualServer.

Describe the solution you'd like
I think WebSocket should be supported by default, or opt-in like this:

apiVersion: k8s.nginx.org/v1alpha1
kind: VirtualServer
metadata:
  name: hac-virtual-server
spec:
  host: {{ .Values.appDomain }}
  upstreams:
  - name: hac-autocomplete-upstream
    service: autocomplete
    port: 8374
    websocket: true
    lb-method: ip_hash
@Dean-Coakley Dean-Coakley added the proposal An issue that proposes a feature request label Jul 16, 2019
@Dean-Coakley
Copy link
Contributor

Hi @trungdq88

Websocket support is a planned feature to be included in the next upcoming ingress controller release.

It will also be available soon via the :edge tag.

Thanks!

@Dean-Coakley
Copy link
Contributor

The Websocket protocol is now supported in VirtualServer and VirtualServerRoute #653 .

It is available via the :edge tag now, and will be included in the upcoming release.

Thanks for the feature request @trungdq88 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal An issue that proposes a feature request
Projects
None yet
Development

No branches or pull requests

2 participants