Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TransportServers in debian AppProtect image #1179

Merged
merged 1 commit into from
Oct 8, 2020
Merged

Conversation

pleshakov
Copy link
Contributor

@pleshakov pleshakov commented Oct 7, 2020

Proposed changes

Previously, the DockerfileWithAppProtectForPlus didn't create the folder /etc/nginx/stream-conf.d. As a result, the IC wasn't able to write generated config for TransportServers, because the directory didn't exist.

The PR fixes the Dockerfile to create that folder.

@pleshakov pleshakov added the bug An issue reporting a potential bug label Oct 7, 2020
Copy link
Member

@lucacome lucacome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe a more descriptive commit message? It's more related to nginx and config than TransportServer itself imo

Previously, the DockerfileWithAppProtectForPlus didn't create
the folder /etc/nginx/stream-conf.d. As a result, the IC wasn't
able to write generated config for TransportServers, because
the directory didn't exist.

The commit fixes the Dockerfile to create that folder.
@pleshakov pleshakov merged commit 971a883 into master Oct 8, 2020
@pleshakov pleshakov deleted the fix-ap-dockerfile branch October 8, 2020 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants