Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve consistency of templates #434

Merged
merged 2 commits into from
Nov 9, 2018
Merged

Improve consistency of templates #434

merged 2 commits into from
Nov 9, 2018

Conversation

Dean-Coakley
Copy link
Contributor

@Dean-Coakley Dean-Coakley commented Nov 9, 2018 •
edited
Loading

Proposed changes

  • Follow the same code style in all templates.
  • Remove unnecessary template logic

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Dean-Coakley Dean-Coakley added the enhancement Pull requests for new features/feature enhancements label Nov 9, 2018
@Dean-Coakley Dean-Coakley self-assigned this Nov 9, 2018
@Dean-Coakley Dean-Coakley merged commit 54e9b4a into master Nov 9, 2018
@Dean-Coakley Dean-Coakley deleted the improve-templates branch November 9, 2018 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov approved these changes

@isaachawley isaachawley isaachawley approved these changes

Assignees

@Dean-Coakley Dean-Coakley

Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dean-Coakley @isaachawley @pleshakov