Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws marketplace id token #5867

Merged
merged 2 commits into from
Jun 26, 2024
Merged

aws marketplace id token #5867

merged 2 commits into from
Jun 26, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Jun 26, 2024 •
edited
Loading

Proposed changes

  • Add id-token write permission to the aws marketplace release job
  • add body to close milestone api call

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested review from a team as code owners June 26, 2024 13:09
@pdabelf5 pdabelf5 changed the base branch from main to release-3.6 June 26, 2024 13:09
@github-actions github-actions bot added github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks labels Jun 26, 2024
@pdabelf5 pdabelf5 closed this Jun 26, 2024
@pdabelf5 pdabelf5 reopened this Jun 26, 2024
@pdabelf5 pdabelf5 enabled auto-merge (squash) June 26, 2024 13:11
@pdabelf5 pdabelf5 merged commit 106a08d into release-3.6 Jun 26, 2024
65 checks passed
@pdabelf5 pdabelf5 deleted the aws-id-token branch June 26, 2024 13:50
pdabelf5 added a commit that referenced this pull request Jun 27, 2024
@pdabelf5
aws marketplace id token (#5867)
839f16d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaun-nx shaun-nx shaun-nx approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

@j1m-ryan j1m-ryan j1m-ryan approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks github_actions Pull requests that update Github_actions code
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pdabelf5 @j1m-ryan @AlexFenlon @shaun-nx