Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ExternalName Services for vs/vsr #641

Merged
merged 1 commit into from
Aug 12, 2019
Merged

Add support for ExternalName Services for vs/vsr #641

merged 1 commit into from
Aug 12, 2019

Conversation

Rulox
Copy link
Contributor

@Rulox Rulox commented Aug 1, 2019

Proposed changes

Upstreams in VS and VSR can reference ExternalName services now.

@Rulox Rulox added the enhancement Pull requests for new features/feature enhancements label Aug 1, 2019
pleshakov
pleshakov suggested changes Aug 1, 2019
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments and suggestions.

internal/k8s/controller.go Outdated Show resolved Hide resolved
internal/k8s/controller.go Outdated Show resolved Hide resolved
internal/k8s/controller.go Show resolved Hide resolved
internal/configs/virtualserver.go Outdated Show resolved Hide resolved
internal/configs/virtualserver_test.go Outdated Show resolved Hide resolved
internal/configs/virtualserver_test.go Outdated Show resolved Hide resolved
Dean-Coakley
Dean-Coakley approved these changes Aug 6, 2019
View reviewed changes
Copy link
Contributor

@Dean-Coakley Dean-Coakley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm pending typo fix

docs/virtualserver-and-virtualserverroute.md Outdated Show resolved Hide resolved
@Rulox Rulox requested a review from pleshakov August 8, 2019 16:03
pleshakov
pleshakov suggested changes Aug 8, 2019
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rulox looks good!
A few small comments and there is a bug :(

internal/configs/virtualserver.go Outdated Show resolved Hide resolved
internal/configs/virtualserver.go Outdated Show resolved Hide resolved
internal/configs/virtualserver_test.go Outdated Show resolved Hide resolved
internal/configs/virtualserver_test.go Show resolved Hide resolved
internal/configs/virtualserver.go Outdated Show resolved Hide resolved
internal/configs/virtualserver_test.go Outdated Show resolved Hide resolved
internal/k8s/controller.go Show resolved Hide resolved
internal/k8s/controller.go Outdated Show resolved Hide resolved
internal/k8s/controller.go Outdated Show resolved Hide resolved
@Rulox Rulox requested a review from pleshakov August 9, 2019 13:50
pleshakov
pleshakov approved these changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Rulox Rulox merged commit a8e9b4f into master Aug 12, 2019
@Rulox Rulox deleted the externalname-vs-vsr branch August 12, 2019 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LorcanMcVeigh LorcanMcVeigh LorcanMcVeigh approved these changes

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

@pleshakov pleshakov pleshakov approved these changes

Assignees
No one assigned
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rulox @pleshakov @Dean-Coakley @LorcanMcVeigh