Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect Deployment ID (NGF) #1304

Closed
Tracked by #793
mpstefan opened this issue Dec 1, 2023 · 3 comments · Fixed by #1597
Closed
Tracked by #793

Collect Deployment ID (NGF) #1304

mpstefan opened this issue Dec 1, 2023 · 3 comments · Fixed by #1597
Assignees
Labels
area/telemetry Issues related to collected telemetry data refined Requirements are refined and the issue is ready to be implemented. size/small Estimated to be completed within ~2 days
Milestone

Comments

@mpstefan
Copy link
Collaborator

mpstefan commented Dec 1, 2023

As a maintainer of NGF
I want to collect a deployment identifier from all participating NGF installations
So that I can correlate telemetry data with every unique installation of NGF even if they exist on the same cluster.

Acceptance

  • The deployment identifier does not contain any characters or information that can reveal the identity of the installer.
  • The deployment identifier is highly likely to be unique across all Kubernetes deployments.
@mpstefan mpstefan added the area/telemetry Issues related to collected telemetry data label Dec 1, 2023
@mpstefan mpstefan added this to the v1.2.0 milestone Dec 1, 2023
@mpstefan mpstefan changed the title Record Deployment ID Collect Deployment ID (NGF) Dec 13, 2023
@mpstefan mpstefan added refined Requirements are refined and the issue is ready to be implemented. size/small Estimated to be completed within ~2 days labels Dec 14, 2023
@bjee19
Copy link
Contributor

bjee19 commented Feb 5, 2024

The deployment identifier is highly likely to be unique across all Kubernetes deployments.

This refers to the same cluster right? Meaning, the deployment identifier is likely to be unique across all other deployments in the same cluster? In addition, we only really care about other NGF deployments in the same cluster right?

Was just thinking of an approach to this issue: does getting the name of the deployment and running it through a hash function work?

@salonichf5 salonichf5 moved this from 🆕 New to 🏗 In Progress in NGINX Gateway Fabric Feb 5, 2024
@mpstefan
Copy link
Collaborator Author

mpstefan commented Feb 5, 2024

I would say we want the deployment id to be unique across all Kubernetes deployments, as stated, because when we want to look at stats for unique deployments vs clusters, we won't be able to do that easily if deployments aren't unique across clusters.

@pleshakov
Copy link
Contributor

I would say we want the deployment id to be unique across all Kubernetes deployments, as stated, because when we want to look at stats for unique deployments vs clusters, we won't be able to do that easily if deployments aren't unique across clusters.

because the cluster ID is unique, even if the deployment ID is not unique among clusters, the combination of cluster ID with deployment ID will be unique though

@salonichf5 salonichf5 self-assigned this Feb 6, 2024
@salonichf5 salonichf5 moved this from 🏗 In Progress to 👀 In Review in NGINX Gateway Fabric Feb 20, 2024
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in NGINX Gateway Fabric Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/telemetry Issues related to collected telemetry data refined Requirements are refined and the issue is ready to be implemented. size/small Estimated to be completed within ~2 days
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants