Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core API: Exact PathMatch #476

Closed
Tracked by #608
kate-osborn opened this issue Mar 17, 2023 · 2 comments · Fixed by #603
Closed
Tracked by #608

Core API: Exact PathMatch #476

kate-osborn opened this issue Mar 17, 2023 · 2 comments · Fixed by #603
Assignees
Labels
area/httproute/core Relates to all Core features of HTTPRoute enhancement New feature or request refined Requirements are refined and the issue is ready to be implemented.
Milestone

Comments

@kate-osborn
Copy link
Contributor

kate-osborn commented Mar 17, 2023

Support Exact PathMatchType in HTTPRoute resource. See https://gateway-api.sigs.k8s.io/references/spec/#gateway.networking.k8s.io/v1beta1.PathMatchType

Acceptance criteria:

Appendix:
Two locations with the same path but different matching (exact and prefix)

    location = /hello {
        return 200 "exact hello\n";
    }

    location /hello {
        return 200 "prefix hello\n";
    }
curl localhost:8090/hello
exact hello

curl localhost:8090/hello/abc
prefix hello

Aha! Link: https://nginx.aha.io/features/NKG-60

@kate-osborn kate-osborn changed the title API Surface: Exact PathMatch Core API: Exact PathMatch Mar 17, 2023
@kate-osborn kate-osborn added enhancement New feature or request area/httproute/core Relates to all Core features of HTTPRoute and removed proposal labels Mar 21, 2023
@kate-osborn kate-osborn added this to the v1.0.0 milestone Mar 21, 2023
@kate-osborn kate-osborn added the refined Requirements are refined and the issue is ready to be implemented. label Mar 24, 2023
@kate-osborn kate-osborn modified the milestones: v1.0.0, v0.4.0 Mar 24, 2023
@sjberman sjberman self-assigned this Apr 27, 2023
@sjberman
Copy link
Contributor

When we say "if two rules have the same path", does this consist of two separate rules, or two separate matches within a rule, or both?

@pleshakov
Copy link
Contributor

@sjberman

When we say "if two rules have the same path", does this consist of two separate rules, or two separate matches within a rule, or both?

two separate rules

however, two separate matches within a rule could be a good case to also check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/httproute/core Relates to all Core features of HTTPRoute enhancement New feature or request refined Requirements are refined and the issue is ready to be implemented.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants