Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect port in the location header for redirects #795

Closed
kate-osborn opened this issue Jun 27, 2023 · 0 comments · Fixed by #801
Closed

Incorrect port in the location header for redirects #795

kate-osborn opened this issue Jun 27, 2023 · 0 comments · Fixed by #801
Assignees
Labels
area/httproute/core Relates to all Core features of HTTPRoute bug Something isn't working refined Requirements are refined and the issue is ready to be implemented.
Milestone

Comments

@kate-osborn
Copy link
Contributor

kate-osborn commented Jun 27, 2023

The port in the location header for an HTTPRoute with a requestRedirect filter must be set based on the rules in the spec: https://gateway-api.sigs.k8s.io/v1alpha2/references/spec/#gateway.networking.k8s.io%2fv1beta1.HTTPRequestRedirectFilter

The conformance tests HTTPRouteRedirectScheme and HTTPRouteRedirectPortAndScheme are failing with errors like the following:
for https scheme, expected redirected port to be 443 or not set, got "80"

or:

for http scheme, expected redirected port to be 80 or not set, got "443"

Acceptance Criteria:

  • Set the port in the location header of a redirect based on the rules in the spec
  • Make sure the conformance tests mentioned above pass
@mpstefan mpstefan added the bug Something isn't working label Jun 27, 2023
@mpstefan mpstefan added this to the v0.5.0 milestone Jun 27, 2023
@mpstefan mpstefan added the area/httproute/core Relates to all Core features of HTTPRoute label Jun 27, 2023
@ciarams87 ciarams87 self-assigned this Jun 28, 2023
@ciarams87 ciarams87 moved this from 🆕 New to 👀 In Review in NGINX Gateway Fabric Jun 28, 2023
@mpstefan mpstefan added the refined Requirements are refined and the issue is ready to be implemented. label Jun 28, 2023
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in NGINX Gateway Fabric Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/httproute/core Relates to all Core features of HTTPRoute bug Something isn't working refined Requirements are refined and the issue is ready to be implemented.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants