-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate functional test in the pipeline #1634
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Mar 1, 2024
salonichf5
force-pushed
the
functional-test
branch
from
March 1, 2024 17:18
b790d6a
to
650c24a
Compare
6 tasks
salonichf5
force-pushed
the
functional-test
branch
4 times, most recently
from
March 7, 2024 21:03
5a34ee8
to
de30454
Compare
pleshakov
reviewed
Mar 7, 2024
sjberman
reviewed
Mar 8, 2024
ciarams87
reviewed
Mar 11, 2024
ciarams87
reviewed
Mar 11, 2024
ciarams87
reviewed
Mar 11, 2024
ciarams87
reviewed
Mar 11, 2024
salonichf5
force-pushed
the
functional-test
branch
from
March 11, 2024 19:47
cea8615
to
00b477a
Compare
sjberman
reviewed
Mar 11, 2024
6 tasks
sjberman
reviewed
Mar 11, 2024
salonichf5
force-pushed
the
functional-test
branch
from
March 11, 2024 21:46
cb02b36
to
478d1ab
Compare
@lucacome would be great if you could review when time permits |
sjberman
approved these changes
Mar 12, 2024
lucacome
reviewed
Mar 12, 2024
lucacome
approved these changes
Mar 12, 2024
pleshakov
approved these changes
Mar 12, 2024
amimimor
pushed a commit
to amimimor/nginx-gateway-fabric
that referenced
this pull request
Apr 3, 2024
Problem: As a user, I want to automate functional tests in the pipeline Solution: To run functional tests in the pipeline, we introduce a new github workflow that sets up the environment to run tests, and upload results Testing: Manual testing by pushing to the branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:
Problem: As a user, I want to automate functional tests in the pipeline
Solution: To run functional tests in the pipeline, we introduce a new github workflow that sets up the environment to run tests, and upload results
Testing: Manual testing by pushing to the branch
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
Closes #1562
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.