Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cherry-pick] Update nginxinc/docs-actions action to v1.0.5 (#2565) #2575

Merged
merged 1 commit into from
Sep 18, 2024
Merged

[cherry-pick] Update nginxinc/docs-actions action to v1.0.5 (#2565) #2575

merged 1 commit into from
Sep 18, 2024

Conversation

nginx-jack
Copy link
Contributor

Cherry pick of #2565

@renovate @nginx-jack
[cherry-pick] Update nginxinc/docs-actions action to v1.0.5 (nginxinc…
beb6852 
…#2565)

| datasource  | package               | from   | to     |
| ----------- | --------------------- | ------ | ------ |
| github-tags | nginxinc/docs-actions | v1.0.4 | v1.0.5 |

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@nginx-jack nginx-jack requested a review from a team as a code owner September 18, 2024 09:17
@nginx-bot nginx-bot
Copy link

nginx-bot bot commented Sep 18, 2024

Hi @nginx-jack!

Thanks for opening this pull request!
Be sure to check out our Contributing Guidelines while you wait for someone on the team to review this.

Please make sure to include the issue number in the PR description to automatically close the issue when the PR is merged.
See Linking a pull request to an issue and our Pull Request Guidelines for more information.

@nginx-bot nginx-bot bot added the community label Sep 18, 2024
@lucacome
Copy link
Member

I'm not entirely sure this PR is needed...it should run the version that is in main but also the workflow never runs since we use forks, but I guess it doesn't hurt 🤷‍♂️

@lucacome lucacome merged commit 6bd6cfb into nginxinc:release-1.4 Sep 18, 2024
23 of 25 checks passed
@nginx-jack
Copy link
Contributor Author

I'm not entirely sure this PR is needed...it should run the version that is in main but also the workflow never runs since we use forks, but I guess it doesn't hurt 🤷‍♂️

If documentation is deployed from release-1.4 (which I believe is the flow used here) then it will use the version of the workflow in that branch. This won't run on the forked branches, as you said. It can only be triggered manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kate-osborn kate-osborn kate-osborn approved these changes

@lucacome lucacome lucacome approved these changes

Assignees

@bjee19 bjee19

Labels
community
Projects
NGINX Gateway Fabric
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nginx-jack @lucacome @kate-osborn @bjee19