Make static mode compatible with provisioner #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
sjberman
reviewed
May 22, 2023
sjberman
reviewed
May 23, 2023
sjberman
approved these changes
May 23, 2023
kate-osborn
suggested changes
May 23, 2023
kate-osborn
approved these changes
May 23, 2023
This commit adds two features for the static mode: - Support configuring a single Gateway resource to watch. - Support not reporting the GatewayClass status, so that it doesn't conflict with the status updates done by the provisioner. Needed by nginx#634
pleshakov
force-pushed
the
feature/static-mode-for-provisioner
branch
from
128ef94 to
8230e48
Compare
miledxz
added a commit
to miledxz/nginx-gateway-fabric
that referenced
this pull request
Jan 14, 2025
This commit adds two features for the static mode: - Support configuring a single Gateway resource to watch. - Support not reporting the GatewayClass status, so that it doesn't conflict with the status updates done by the provisioner. Needed by nginx#634
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two features for the static mode:
Needed by #634