Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pkg imported more than once #836

Closed
wants to merge 1 commit into from
Closed

chore: pkg imported more than once #836

wants to merge 1 commit into from

Conversation

testwill
Copy link

Proposed changes

Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:

Problem: package "sigs.k8s.io/gateway-api/apis/v1beta1" is being imported more than once

Solution: package "sigs.k8s.io/gateway-api/apis/v1beta1" is only imported once

Testing: Describe any testing that you did.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #ISSUE

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@testwill testwill requested a review from a team as a code owner July 10, 2023 02:28
@sjberman sjberman added the chore Pull requests for routine tasks label Jul 10, 2023
@sjberman
Copy link
Collaborator

@testwill Thanks for the contribution! This change should already be handled in this PR: #809.

@testwill testwill closed this Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants