Skip to content

Commit afb2858

Browse files
committed
Adds helper methods to Lua for registering
1 parent fc21994 commit afb2858

File tree

5 files changed

+14
-10
lines changed

5 files changed

+14
-10
lines changed

analyze_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2110,7 +2110,7 @@ func TestAnalyze_lua(t *testing.T) {
21102110
err := analyze("nginx.conf", tc.stmt, ";", tc.ctx, &ParseOptions{
21112111
MatchFuncs: []MatchFunc{MatchLua},
21122112
LexOptions: LexOptions{
2113-
Lexers: []RegisterLexer{LexWithLexer(lua, lua.DirectiveNames()...)},
2113+
Lexers: []RegisterLexer{lua.RegisterLexer()},
21142114
},
21152115
})
21162116

build_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ var buildFixtures = []buildFixture{
260260
},
261261
{
262262
name: "lua block",
263-
options: BuildOptions{Builders: []RegisterBuilder{BuildWithBuilder(lua, lua.DirectiveNames()...)}},
263+
options: BuildOptions{Builders: []RegisterBuilder{lua.RegisterBuilder()}},
264264
parsed: Directives{
265265
{
266266
Directive: "content_by_lua_block",
@@ -273,7 +273,7 @@ var buildFixtures = []buildFixture{
273273
},
274274
{
275275
name: "set_by_lua_block",
276-
options: BuildOptions{Builders: []RegisterBuilder{BuildWithBuilder(lua, lua.DirectiveNames()...)}},
276+
options: BuildOptions{Builders: []RegisterBuilder{lua.RegisterBuilder()}},
277277
parsed: Directives{
278278
{
279279
Directive: "set_by_lua_block",

lex_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -432,7 +432,7 @@ func TestLex(t *testing.T) {
432432

433433
lua := &Lua{}
434434
options := LexOptions{
435-
Lexers: []RegisterLexer{LexWithLexer(lua, lua.DirectiveNames()...)},
435+
Lexers: []RegisterLexer{lua.RegisterLexer()},
436436
}
437437
i := 0
438438

lua.go

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import (
77

88
type Lua struct{}
99

10-
func (l *Lua) DirectiveNames() []string {
10+
func (l *Lua) directiveNames() []string {
1111
return []string{
1212
"init_by_lua_block",
1313
"init_worker_by_lua_block",
@@ -28,6 +28,10 @@ func (l *Lua) DirectiveNames() []string {
2828
}
2929
}
3030

31+
func (l *Lua) RegisterLexer() RegisterLexer {
32+
return LexWithLexer(l, l.directiveNames()...)
33+
}
34+
3135
//nolint:funlen,gocognit,gocyclo,nosec
3236
func (l *Lua) Lex(s *SubScanner, matchedToken string) <-chan NgxToken {
3337
tokenCh := make(chan NgxToken)
@@ -146,8 +150,8 @@ func (l *Lua) Lex(s *SubScanner, matchedToken string) <-chan NgxToken {
146150
return tokenCh
147151
}
148152

149-
func (l *Lua) RegisterBuilder() []string {
150-
return l.DirectiveNames()
153+
func (l *Lua) RegisterBuilder() RegisterBuilder {
154+
return BuildWithBuilder(l, l.directiveNames()...)
151155
}
152156

153157
func (l *Lua) Build(stmt *Directive) string {

parse_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1709,7 +1709,7 @@ var parseFixtures = []parseFixture{
17091709
ErrorOnUnknownDirectives: true,
17101710
MatchFuncs: []MatchFunc{MatchLua},
17111711
LexOptions: LexOptions{
1712-
Lexers: []RegisterLexer{LexWithLexer(lua, lua.DirectiveNames()...)},
1712+
Lexers: []RegisterLexer{lua.RegisterLexer()},
17131713
},
17141714
}, Payload{
17151715
Status: "ok",
@@ -1838,7 +1838,7 @@ var parseFixtures = []parseFixture{
18381838
ErrorOnUnknownDirectives: true,
18391839
MatchFuncs: []MatchFunc{MatchLua},
18401840
LexOptions: LexOptions{
1841-
Lexers: []RegisterLexer{LexWithLexer(lua, lua.DirectiveNames()...)},
1841+
Lexers: []RegisterLexer{lua.RegisterLexer()},
18421842
},
18431843
}, Payload{
18441844
Status: "ok",
@@ -1930,7 +1930,7 @@ var parseFixtures = []parseFixture{
19301930
ParseComments: true,
19311931
MatchFuncs: []MatchFunc{MatchLua},
19321932
LexOptions: LexOptions{
1933-
Lexers: []RegisterLexer{LexWithLexer(lua, lua.DirectiveNames()...)},
1933+
Lexers: []RegisterLexer{lua.RegisterLexer()},
19341934
},
19351935
}, Payload{
19361936
Status: "ok",

0 commit comments

Comments
 (0)