-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-root container #102
Comments
I'm also very interested in this change being made. Any idea over what sort of time frame we can hope to see the PR merged and released? |
Hi @alex1989hu thanks for the PR! I think moving to non-root container makes sense, but I'm not sure about scratch. Alpine doesn't add much overhead to the scratch image and it's pretty secure (it's like one of their main goals) and you get a shell to attach to in case you need to debug something. Do you have any data about images size or vulnerabilities of Alpine? Cheers. |
Hello @lucacome, your welcome 👍 When I wrote reducing attack surface I was thinking about minimizing the possibility of arbitrary code execution. If there is no shell, then you can not do anything except running the Go binary Finally, you asked me to provide image sizes, I have good news:
|
Is your feature request related to a problem? Please describe.
Using
nginx-prometheus-exporter
in security-enhanced (like activePodSecurityPolicy
) Kubernetes (or OpenShift) cluster requires non-root containers. It is common to usescratch
image to reduce attack surface and get a smaller final image.Describe the solution you'd like
USER
in Dockerfilescratch
imageDescribe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
nginx-prometheus-exporter
is written in Go, thusalpine:3.11
is not needed to run it.The text was updated successfully, but these errors were encountered: