Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support logger injection #484

Closed
ciarams87 opened this issue Aug 30, 2023 · 7 comments · Fixed by #841
Closed

Support logger injection #484

ciarams87 opened this issue Aug 30, 2023 · 7 comments · Fixed by #841
Assignees
@lucacome

Comments

@ciarams87
Copy link
Member

As a user of the prometheus exporter as a library
I would like a mechanism to inject a logger
So that I can provide my own logging structure
@ciarams87 ciarams87 mentioned this issue Aug 30, 2023
Merged
6 tasks
@brianehlert
Copy link

Hey @ciarams87
Not a lot of information here about what this entails.
Are there any impacts on core prometheus exporter users?

@lucacome
Copy link
Member

lucacome commented Aug 30, 2023 •
edited
Loading

I think this should be possible with the new changes made in #420

@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot added the stale Pull requests/issues with no activity label Nov 29, 2023
@lucacome lucacome mentioned this issue Dec 4, 2023
Closed
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 10, 2023
@kate-osborn
Copy link

I think this should be possible with the new changes made in #420

@lucacome The logger we use in NGF (logr.Logger) does not implement the log.Logger interface so this is still an issue for us.

@lucacome lucacome reopened this Dec 11, 2023
@lucacome lucacome added backlog candidate Pull requests/issues that are candidates to be backlog items and removed stale Pull requests/issues with no activity labels Dec 11, 2023
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot added the stale Pull requests/issues with no activity label Mar 11, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 21, 2024
@lucacome lucacome removed the stale Pull requests/issues with no activity label Jun 20, 2024
@lucacome lucacome reopened this Jun 20, 2024
@sindhushiv sindhushiv added backlog Pull requests/issues that are backlog items and removed backlog candidate Pull requests/issues that are candidates to be backlog items labels Jul 31, 2024
@lucacome lucacome mentioned this issue Sep 10, 2024
Merged
6 tasks
@lucacome lucacome self-assigned this Sep 10, 2024
@lucacome lucacome removed the backlog Pull requests/issues that are backlog items label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucacome lucacome

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch to slog nginxinc/nginx-prometheus-exporter
5 participants
@lucacome @brianehlert @sindhushiv @ciarams87 @kate-osborn