Fix typographical error #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove a duplicate "that were" in metric description
|
Hi @rwenz3l thanks for the PR! I noticed that the same typo is in the code as well here https://github.com/nginxinc/nginx-prometheus-exporter/blob/main/collector/nginx_plus.go#L349 do you want to update it there too? |
lucacome
approved these changes
Aug 27, 2022
|
@rwenz3l I fixed the other typo and I'm merging this. Thanks again! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a duplicate "that were" in metric description
Proposed changes
While adding metrics from the README to our grafana dashboards I found a small error in the description. This fixes just that.
Checklist
Before creating a PR, run through this checklist and mark each as complete.